Make typing optional#179
Merged
bbc2 merged 7 commits intotheskumar:masterfrom Dec 21, 2019
Merged
Conversation
5 similar comments
- Fall back to `collections.namedtuple` for `Binding` when typing is not present - Add import guards to all imports - Fixes theskumar#178 Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
techalchemy
force-pushed
the
bugfix/conditional-typing-import
branch
from
d031087 to
7a90934
Compare
Contributor
Author
|
Is this change something you are willing to consider? It should be fairly straightforward to use this approach and it avoids the extra imports when not running under a type checker / in an editor |
bbc2
requested changes
Jun 10, 2019
Collaborator
bbc2
left a comment
bbc2
left a comment
There was a problem hiding this comment.
Thank you for the pull request. I left a few inline comments but I'm overall OK with the change.
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
- Fix local test failures Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Signed-off-by: Dan Ryan <dan.ryan@canonical.com>
Contributor
Author
|
Sorry for taking so incredibly long to update this, real life happened and I wasn't able to do much open source work recently. Luckily I am able to catch back up and it looks like the updates since I worked on this were not very drastic, so I went ahead and caught back up with master and addressed / replied to the relevant comments. Let me know how you'd like to move forward! |
bbc2
approved these changes
Dec 21, 2019
johnbergvall
pushed a commit
to johnbergvall/python-dotenv
that referenced
this pull request
Aug 13, 2021
- Fall back to `collections.namedtuple` for `Binding` when typing is not present - Add import guards to all imports - Fixes theskumar#178 - Add missing coverage config to setup.cfg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collections.namedtupleforBindingwhen typing isnot present
Signed-off-by: Dan Ryan dan@danryan.co