Add a cron job for testing third-party users of typing_extensions#206
Merged
Conversation
Member
Author
|
Links to the |
AlexWaygood
force-pushed
the
cron-job
branch
3 times, most recently
from
d368b9b to
284a6f4
Compare
AlexWaygood
changed the title
AlexWaygood
changed the title
Member
|
Thanks, this is great! I'll wait for some time in case the maintainers of these libraries have some feedback. |
srittau
requested changes
May 30, 2023
srittau
left a comment
srittau
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This is very useful.
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
srittau
approved these changes
May 30, 2023
srittau
left a comment
srittau
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but I haven't reviewed the actual implementation.
JelleZijlstra
added a commit
that referenced
this pull request
Jun 1, 2023
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #198.
As well as the packages suggested by Jelle in #198, I also added
typeguardandcattrs. Both are popular packages that usetyping_extensionsextensively.typeguard, as you can see by the CI on this PR, is currently broken by the same change that brokepydantic,typing_inspectandtyped-argument-parse(reimplementingLiteralon 3.8 and 3.9, as well as 3.7).cattrswasn't broken by v4.6.0, but given the way they're peering into our internals, it wouldn't surprise me if we broke them at some point.Note that while the
typeguardfailures show the usefulness of having a CI job like this, thetyped-argument-parsertests are currently passing despite us apparently having broken them. That shows the limits of a CI job like this: we're dependent on third-party projects having reasonable test coverage, or this won't help us much.I didn't include
beartype, as their CI is currently failing on theirmainbranch, their CI setup is somewhat complicated, and they don't fully supporttyping_extensionsanyway.My thinking is that if a third-party test starts failing:
Literalchange), we immediately skip the test in CI, open an issue over at the third-party project, and unskip the test as soon as the issue is fixed in the third-party project. A release shouldn't necessarily be considered blocked if a test is skipped, but we should at least make the third-party project aware of the breakage before the release, and give them a reasonable amount of time to fix it before we cut a release.