[WIP] Use symbol provider from new language server to place code lenses in tests#2197
Closed
DonJayamanne wants to merge 1 commit into
Closed
[WIP] Use symbol provider from new language server to place code lenses in tests#2197DonJayamanne wants to merge 1 commit into
DonJayamanne wants to merge 1 commit into
Conversation
Author
|
This relies on #2050 |
Codecov Report
@@ Coverage Diff @@
## master #2197 +/- ##
=========================================
- Coverage 79.84% 79.8% -0.05%
=========================================
Files 310 312 +2
Lines 14359 14394 +35
Branches 2547 2558 +11
=========================================
+ Hits 11465 11487 +22
- Misses 2882 2895 +13
Partials 12 12
Continue to review full report at Codecov.
|
|
When you get a moment, rebuild this PR, the mac agents recently were updated to python 3.7. |
Member
|
@DonJayamanne is this still a WIP? |
5 tasks
Member
|
@DonJayamanne #2456 is this PR to just add language server support so we can get it for this release. |
Author
|
closing as the work has been completed in another PR by @ericsnowcurrently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1948
"1.2.3", not"^1.2.3")package-lock.jsonhas been regenerated if dependencies have changed