Don't trigger keyboard shortcuts while searching

[fiendish]

Issue Type: Bug
The "Run Selection/Line in Python Terminal" keyboard shortcut added by the extension activates (it defaults to Shift+Enter) while searching (shift+enter is the standard for finding the previous match).

1. Open a Python file.
2. Select something in the file.
3. Press Cmd+F or Ctrl+F to start searching.
4. Press Shift+Enter to find the previous match.
5. Watch the Terminal pop up, probably with some garbage NameErrors about whatever you selected not being defined.

This is because Shift+Enter is the default keyboard shortcut for "Run Selection/Line in Python Terminal", but that shouldn't be firing during a search.

VS Code version: Code 1.24.1 (24f62626b222e9a8313213fb64b10d741a326288, 2018-06-13T17:41:50.128Z)
OS version: Darwin x64 17.6.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled vpx_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	16.00GB (2.34GB free)
Process Argv	/Applications/Visual Studio Code.app/Contents/MacOS/Electron .
Screen Reader	no
VM	0%

Extensions (10)

Extension	Author (truncated)	Version
bracket-pair-colorizer	Coe	1.0.58
markdown-preview-github-styles	bie	0.1.2
vscode-markdownlint	Dav	0.18.0
jupyter	don	1.1.4
gc-excelviewer	Gra	2.1.24
rainbow-csv	mec	0.4.2
python	ms-	2018.6.0
rewrap	stk	1.9.1
python-extended-snippets	tus	0.0.1
markdown-all-in-one	yzh	1.5.0

Originally posted at microsoft/vscode#53151 and moved here.

[d3r3kk]

Thanks for the report @fiendish!

This is the keybinding change we recently implemented: #1875

@DonJayamanne, @qubitron, I think we have indeed found a clash. (I personally missed this one as I use F3/Shift+F3 for traversing search results).

[qubitron]

@d3r3kk @DonJayamanne so are we back to Ctrl+Alt+Enter or can we work around this issue?

[DonJayamanne]

so are we back to Ctrl+Alt+Enter

Unfortunately yes.

can we work around this issue?

I can't find a way to work around this issue. Isn't documented either.

[fiendish]

In the original issue I posted against vscode which was diverted here, the response back from them was "the python ext needs to add a special context menu to the keybinding to make sure that the search is not focused.". Not being a vscode extension developer myself, I don't quite know what that means.

[d3r3kk]

... so Alt+Shift+Enter perhaps?

edit: added screenshot for proposed key-combination...

[DonJayamanne]

We should be able to use alt+shift+enter.
Provided we add the necessary when clauses.